Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: localosmosis to work for testing cosmwasm contracts #1640

Merged
merged 5 commits into from
Jun 1, 2022
Merged

fix: localosmosis to work for testing cosmwasm contracts #1640

merged 5 commits into from
Jun 1, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Jun 1, 2022 •
edited
Loading

Closes: #XXX

What is the purpose of the change

There were several issues requiring the user to do some hacks to get localosmosis work with cosmwasm contracts.

This PR does the following:

  • use apt-get in Dockerfile as apk is an alpine specific command
  • run setup.sh on start up
    • if it is run as a Dockerfile "RUN" directive, it will not mount state on a volume for some reason. We want the state to be preserved
  • make basedenom in genesis be "uosmo" instead of "stake"
    • this was causing issues with testing cosmwasm contracts

Added / changed the following Makefile commands:

  • make localnet-remove - removes the local state, bringing the chain to genesis
  • make localnet-stop - stops the chain, allowing to continue from previous chain state

Testing and Verifying

This change can be verified as follows:

  • make localnet-build
  • make localnet-start
  • make localnet-remove

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? yes
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
  • How is the feature or change documented? README

@p0mvn p0mvn added the A:backport/v9.x Do not use. backport patches to v9.x branch label Jun 1, 2022
@p0mvn p0mvn changed the title fix: localosmosis to initialize state and mount it on a volume fix: localosmosis to work for testing cosmwasm contracts Jun 1, 2022
@p0mvn p0mvn marked this pull request as ready for review June 1, 2022 18:47
@p0mvn p0mvn requested a review from a team June 1, 2022 18:47
@p0mvn p0mvn merged commit d5cd033 into main Jun 1, 2022
@p0mvn p0mvn deleted the roman/localosmosis branch June 1, 2022 19:31
mergify bot pushed a commit that referenced this pull request Jun 1, 2022
@p0mvn @mergify
fix: localosmosis to work for testing cosmwasm contracts (#1640)
d2ee38f 
* first working version

* better makefile commands and docs

* fix osmosisd start script to expose rpc port

* changelog

(cherry picked from commit d5cd033)
@mergify mergify bot mentioned this pull request Jun 1, 2022
Merged
p0mvn added a commit that referenced this pull request Jun 1, 2022
@mergify @p0mvn
fix: localosmosis to work for testing cosmwasm contracts (#1640) (#1641)
8e2b024 
* first working version

* better makefile commands and docs

* fix osmosisd start script to expose rpc port

* changelog

(cherry picked from commit d5cd033)

Co-authored-by: Roman <roman@osmosis.team>
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Closed
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

Assignees
No one assigned
Labels
A:backport/v9.x Do not use. backport patches to v9.x branch
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p0mvn @alexanderbez